Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/snowflake): fix type annotations + refactor get_connect_args #7004

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix(ingest/snowflake): fix type annotations + refactor get_connect_args #7004

merged 1 commit into from
Jan 11, 2023

Commits on Jan 11, 2023

  1. fix(ingest/snowflake): fix type annotations + refactor get_connect_args 

    In the latest releast of types-PyOpenSSL, they removed their dep on
types-cryptography (python/typeshed#9459). This
caused mypy to start using the type annotations provided by the
cryptography package, which caused an issue in our build. Example build
failure: https://github.com/datahub-project/datahub/actions/runs/3888835554/jobs/6636552750
    @hsheth2
    hsheth2 committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c3b3302 View commit details
    Browse the repository at this point in the history