Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ingest): upgrade to mypy 1.0.0 #7313

Merged
merged 1 commit into from
Feb 10, 2023
Merged

chore(ingest): upgrade to mypy 1.0.0 #7313

merged 1 commit into from
Feb 10, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 10, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 10, 2023
@jjoyce0510 jjoyce0510 merged commit 582fdf9 into datahub-project:master Feb 10, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2
chore(ingest): upgrade to mypy 1.0.0 (datahub-project#7313)
fc2b0f0
@cburroughs cburroughs mentioned this pull request Mar 3, 2023
Merged
3 tasks
cburroughs added a commit to cburroughs/datahub that referenced this pull request Mar 3, 2023
@cburroughs
fix(ingest): limt typing_extensions classes to those available in min…
521eff7 
… version

Depending on python versions, the minimum typing_extensions is
>=3.7.4.3 or >=3.10.0.2. (And needs to stay that way for Airflow.)
However, typing_extensions.Self is only available starting in 4.0.0
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#added-in-version-400

This partially reverts datahub-project#7313 to avoid the use of
typing_extensions.Self.

Fixes datahub-project#7370
@hsheth2 hsheth2 deleted the mypy-1 branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510