logging(cli): dropping neo4j message to debug to avoid confusion #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
anshbansal
approved these changes
Feb 14, 2023
looppi
pushed a commit
to looppi/datahub
that referenced
this pull request
Feb 15, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original log message in the cli was added when DataHub's default graph backend was neo4j and we wanted to make sure that people were in the know when we selected elastic by default for them.
1.5 yrs later: people are actually more confused about this message and wonder whether they should instead be using neo4j and why.
Example: https://datahubspace.slack.com/archives/CV2KB471C/p1676324646452419
This PR drops that message to debug level.
Checklist