feat(ingest): powerbi # set dataset_type_mapping to all supported data platform #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Mar 17, 2023
| Oracle: oracle | ||
| Sql: mssql | ||
| GoogleBigQuery: bigquery | ||
| PostgreSql: |
There was a problem hiding this comment.
The whole purpose is to make the user do LESS. Why would we include this in our sample recipe? Please reove the entire field from our starter recipe
There was a problem hiding this comment.
This to give example for how to set the platform_instance with recipe, I will remove it in next PR when we make this field deprecated
There was a problem hiding this comment.
It is for reference for how to set platform_instance. We can remove this field once we deprecated it in next PR.
jjoyce0510
reviewed
Mar 17, 2023
jjoyce0510
reviewed
Mar 17, 2023
| @@ -651,7 +656,7 @@ def test_powerbi_ingest_urn_lower_case( | |||
| }, | |||
| } | |||
| ) | |||
|
|
|||
| pipeline.config | |||
…/datahub-fork into master+default-dataset-mapping
…/datahub-fork into master+default-dataset-mapping
…que/datahub into master+default-dataset-mapping
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
PR: #7632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.