test(ingest/dbt): add test for column meta match #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was working previously as well. The other changes are simply refactoring.
github-actions
bot
added
the
ingestion
| if ( | ||
| operation_type == Constants.ADD_TAG_OPERATION | ||
| and operation_config[Constants.TAG] | ||
| ): | ||
| tag = operation_config[Constants.TAG] | ||
| tag_id = _get_best_match(match, "tag") | ||
| if isinstance(tag_id, str): |
There was a problem hiding this comment.
This if condition is missing in refractored code but also it does not seem required, as match object essentially returns a string if single argument is passed - https://docs.python.org/3/library/re.html#re.Match.group
There was a problem hiding this comment.
Yep the get_best_match method always returned a string so it wasn't necessary
anshbansal
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was working previously as well. The other changes are simply refactoring.
Checklist