-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/looker): correct looker/lookml capability reports #7683
Conversation
Also updating the capability report here datahub-project#7683.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7683 +/- ##
==========================================
- Coverage 74.87% 74.87% -0.01%
==========================================
Files 353 353
Lines 35386 35379 -7
==========================================
- Hits 26496 26489 -7
Misses 8890 8890
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@capability( | ||
SourceCapability.OWNERSHIP, "Enabled by default, configured using `extract_owners`" | ||
) | ||
@capability( | ||
SourceCapability.USAGE_STATS, "Can be enabled using `extract_usage_history`" | ||
SourceCapability.USAGE_STATS, | ||
"Enabled by default, configured using `extract_usage_history`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this decorator actually do? Does this update the docs or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it feeds into our doc generation system
Checklist