Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/looker): correct looker/lookml capability reports #7683

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 24, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 24, 2023
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Mar 24, 2023
Also updating the capability report here datahub-project#7683.
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (1324231) 74.87% compared to head (c008687) 74.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7683      +/-   ##
==========================================
- Coverage   74.87%   74.87%   -0.01%     
==========================================
  Files         353      353              
  Lines       35386    35379       -7     
==========================================
- Hits        26496    26489       -7     
  Misses       8890     8890              
Flag Coverage Δ
pytest-testIntegration 50.83% <100.00%> (-0.01%) ⬇️
pytest-testIntegrationBatch1 36.47% <100.00%> (+<0.01%) ⬆️
pytest-testQuick 63.56% <100.00%> (+0.01%) ⬆️
pytest-testSlowIntegration 32.94% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/datahub/ingestion/source/looker/looker_source.py 67.82% <100.00%> (+0.28%) ⬆️
...c/datahub/ingestion/source/looker/lookml_source.py 84.41% <100.00%> (+0.36%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@capability(
SourceCapability.OWNERSHIP, "Enabled by default, configured using `extract_owners`"
)
@capability(
SourceCapability.USAGE_STATS, "Can be enabled using `extract_usage_history`"
SourceCapability.USAGE_STATS,
"Enabled by default, configured using `extract_usage_history`",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this decorator actually do? Does this update the docs or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it feeds into our doc generation system

@hsheth2 hsheth2 enabled auto-merge (squash) March 26, 2023 22:58
@hsheth2 hsheth2 merged commit 6d04511 into datahub-project:master Mar 26, 2023
@hsheth2 hsheth2 deleted the looker-capabilities branch March 26, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants