-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ingest): formatting + cleanup MCPW usages #7706
chore(ingest): formatting + cleanup MCPW usages #7706
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7706 +/- ##
==========================================
- Coverage 74.97% 67.07% -7.90%
==========================================
Files 353 353
Lines 35406 35398 -8
==========================================
- Hits 26545 23744 -2801
- Misses 8861 11654 +2793
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
@@ -891,10 +889,7 @@ def _to_metadata_events( # noqa: C901 | |||
|
|||
mce = MetadataChangeEvent(proposedSnapshot=dataset_snapshot) | |||
mcp = MetadataChangeProposalWrapper( | |||
entityType="dataset", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is cool, we guess the type from the urn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - I'm trying to remove these where possible since it feels like a bunch of clutter
Checklist