Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(okta): add how to use email in urns #7708

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f348113) 74.97% compared to head (0b7d5f8) 74.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7708      +/-   ##
==========================================
- Coverage   74.97%   74.97%   -0.01%     
==========================================
  Files         353      353              
  Lines       35406    35406              
==========================================
- Hits        26547    26545       -2     
- Misses       8859     8861       +2     
Flag Coverage Δ
pytest-testIntegration 50.92% <ø> (-0.01%) ⬇️
pytest-testIntegrationBatch1 36.48% <ø> (ø)
pytest-testQuick 63.57% <ø> (ø)
pytest-testSlowIntegration 32.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/src/datahub/ingestion/source/identity/okta.py 82.43% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anshbansal anshbansal merged commit f0a675f into master Mar 31, 2023
@anshbansal anshbansal deleted the aseem-improve-okta-docs branch March 31, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants