Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): fix ownership emission for groups #7751

Merged
merged 1 commit into from
Apr 5, 2023
Merged

feat(sdk): fix ownership emission for groups #7751

merged 1 commit into from
Apr 5, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 4, 2023 •
edited
Loading

  • Fix a bug where only the last admin was saved under ownership
  • Renaming admin -> owner to match the UI
  • Also uses the new file inlining support to reduce copying.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(sdk): rename admins to owners + fix ownership emission
9d777b0 
Also uses the new file inlining support to reduce copying.
@hsheth2 hsheth2 requested a review from yoonhyejin April 4, 2023 18:53
@hsheth2 hsheth2 changed the title feat(sdk): rename admins to owners + fix ownership emission feat(sdk): fix ownership emission for groups Apr 4, 2023
@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Apr 4, 2023
gabe-lyons
gabe-lyons reviewed Apr 4, 2023
View reviewed changes
metadata-ingestion/src/datahub/api/entities/corpgroup/corpgroup.py
@@ -65,10 +67,12 @@ class CorpGroup(BaseModel):
overrideEditable: bool = False
picture_link: Optional[str] = None
slack: Optional[str] = None
admins: List[Union[str, CorpUser]] = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not make this a breaking change- just remove it from docs and mark it as deprecated please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already taken care of by this line

_rename_admins_to_owners = pydantic_renamed_field("admins", "owners")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

jjoyce0510
jjoyce0510 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@anshbansal anshbansal merged commit e71c0d3 into datahub-project:master Apr 5, 2023
@hsheth2 hsheth2 deleted the group-admins branch April 5, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@yoonhyejin yoonhyejin Awaiting requested review from yoonhyejin

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsheth2 @gabe-lyons @jjoyce0510 @anshbansal