feat(elasticsearch): Add servlet which provides an endpoint for a healthcheck on the ES cl… #7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Fixed
Show resolved
Hide resolved
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Fixed
Show fixed
Hide fixed
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Fixed
Show resolved
Hide resolved
| * Checks the memoized cache for the latest elastic health check result | ||
| * @return The ResponseEntity containing the health check result | ||
| */ | ||
| @GetMapping(path = "/elastic", produces = MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
Where is the combined healthcheck endpoint. Specifically, the one that produces a common message with all of the component checks? The one which would be used by a readiness check.
There was a problem hiding this comment.
Still to come.... :D
There was a problem hiding this comment.
Still to come.... :D
| private Supplier<ResponseEntity<String>> memoizedSupplier; | ||
|
|
||
| public HealthCheckController () { | ||
| this.memoizedSupplier = Suppliers.memoizeWithExpiration( |
david-leifker
approved these changes
Apr 19, 2023
iprentic
added a commit
that referenced
this pull request
Apr 27, 2023
…lthcheck on the ES cl… (#7799) Co-authored-by: Indy Prentice <[email protected]> Co-authored-by: Pedro Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ient
Checklist