Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): improve quickstart stability #7839

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 17, 2023

  • Increase quickstart timeout from 8 to 10 minutes.
  • Only run docker compose up when required, instead of wasting compute by running it every 30 seconds.

Hopefully this will reduce quickstart errors in OSS and in CI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

- Increase quickstart timeout from 8 to 10 minutes.
- Only run `docker compose up` when required, instead of wasting
  compute by running it every 30 seconds.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 17, 2023
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 399e333 into datahub-project:master Apr 18, 2023
@hsheth2 hsheth2 deleted the docker-quickstart-stability branch April 18, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants