feat(urn) Add validator to reject URNs which contain the character we plan to u… #7859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se as a delimiter
iprentic
requested review from
RyanHolstien,
chriscollins3456 and
david-leifker
chriscollins3456
approved these changes
Apr 19, 2023
| @@ -170,6 +170,9 @@ public static class IngestProposalResult { | |||
|
|
|||
| private static final int URN_NUM_BYTES_LIMIT = 512; | |||
|
|
|||
| // TODO(iprentic): Move this to a common utils location once used in other places | |||
| private static final String DELIMITER_SEPARATOR = "␟"; | |||
There was a problem hiding this comment.
Might be less visually weird to have this as the character code rather than a blank looking String in case someone edits this without understanding it.
There was a problem hiding this comment.
I like the way it is actually
RyanHolstien
approved these changes
Apr 19, 2023
david-leifker
approved these changes
Apr 20, 2023
iprentic
added a commit
that referenced
this pull request
Apr 27, 2023
… plan to u… (#7859) Co-authored-by: Indy Prentice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se as a delimiter
Checklist