Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lineagecounts) Include entities that are filtered out due to sibling logic in the filtered count of lineage counts #8152

Merged
merged 1 commit into from
May 31, 2023

Conversation

iprentic
Copy link
Contributor

The pill counts do not match the number of entities shown in the table. This is because in both cases, we filter out non-existent and duplicate entities between siblings. However, in the sibling case, when duplicates are removed, they were double counted in the total, but not added to the filtered count. The pill calculates the number to show as the total minus the filtered. Thus, the pill was overcounting the number of results.

Update the logic to add the number of filtered entities to the result, so that the count is displayed correctly on the UI

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 30, 2023
@david-leifker david-leifker merged commit 6c445c8 into master May 31, 2023
@david-leifker david-leifker deleted the pillCounts branch May 31, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants