-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(patch): support datajob input output #8190
feat(patch): support datajob input output #8190
Conversation
System.out.println(response.get().getResponseContent()); | ||
|
||
} catch (URISyntaxException | IOException | ExecutionException | InterruptedException e) { | ||
System.out.println(Arrays.asList(e.getStackTrace())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this system out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this test is more of an example usage for the Java SDK. It's set to ignore for CI and the System.out gives output of what happens during local testing.
return this; | ||
} | ||
|
||
private ObjectNode createEdgeValue(Urn urn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces the timestamp for the added edge to be current time, which doesn't work if the producer wants to set a different time (e.g. processing an audit log and finding a job that was run a day ago). We need to expand the API to support passing in the full edge as well. Perhaps there can be a default implementation like this as a shortcut for people who don't care.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will add it
…stien/datahub into feat/dataJobLineagePatch
Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: david-leifker <[email protected]>
Checklist