fix(ingest/druid) Handling gracefully if no table returned in a schema #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `view` schema to the default deny
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Jun 9, 2023
| ) | ||
|
|
||
| result = connection.execute(text(query)) | ||
| return [row.TABLE_NAME for row in result] if result.rowcount > 0 else [] |
There was a problem hiding this comment.
What exactly is this result.rowcount > 0 check doing? Does sqlalchemy normally error if the row count is 0?
There was a problem hiding this comment.
I threw an error (This result object does not return rows. It has been closed automatically.) if no rows were returned and it tried to iterate over the results.
There was a problem hiding this comment.
This seems like a druid sqlalchemy bug to me... or something that should be configurable. Why would returning no rows result in an error?
Would at least prefer if we referenced the existing code (e.g. wrapped with a try catch) rather than overwriting it, if possible
asikowitz
approved these changes
Jun 12, 2023
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewschema to the default denyChecklist