-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/bigquery_v2): enable platform instance using project id #8216
feat(ingest/bigquery_v2): enable platform instance using project id #8216
Conversation
…atahub-project#8142) Co-authored-by: Andrew Sikowitz <[email protected]>
@@ -140,7 +142,8 @@ def cleanup(config: BigQueryV2Config) -> None: | |||
@support_status(SupportStatus.CERTIFIED) | |||
@capability( | |||
SourceCapability.PLATFORM_INSTANCE, | |||
"Not supported since BigQuery project ids are globally unique", | |||
"Platform instance is pre-set to the BigQuery project id, " | |||
"but not added to urns as project ids are included in the container path.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "not added to urns" part can be a #
comment, but doesn't need to show up in our docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah guess that's an implementation detail
Deployment failed with the following error:
|
@asikowitz re-queuing CI since it looks like it failed due to the Github incident yesterday |
…atahub-project#8216) Co-authored-by: Adrián Pertíñez <[email protected]> Co-authored-by: Harshal Sheth <[email protected]>
Cherry-pick of 743439c
Checklist