Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-react): adds the possibility to track events through GA4 #8231

Merged
merged 23 commits into from
Jun 24, 2024
Merged

feat(web-react): adds the possibility to track events through GA4 #8231

merged 23 commits into from
Jun 24, 2024

Conversation

PatrickfBraz
Copy link
Contributor

@PatrickfBraz PatrickfBraz commented Jun 13, 2023 •
edited
Loading

Context

These changes are intended to allow the sending of events from the platform to GA4.

NOTE: GA3 is no longer supported

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@PatrickfBraz
Copy link
Contributor Author

I'm still working on this PR

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jun 13, 2023
@PatrickfBraz PatrickfBraz reopened this Jun 13, 2023
@PatrickfBraz PatrickfBraz changed the title [Web react] Adds the possibility to track events through GA4 feat(web-react): adds the possibility to track events through GA4 Jun 14, 2023
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jun 23, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Jul 18, 2023

@PatrickfBraz is this ready for review?

@PatrickfBraz
Copy link
Contributor Author

Yes @hsheth2. Is ready!
I would even like opinions on maybe there is another (better) way to allow GA4 and GA3

@PatrickfBraz
Copy link
Contributor Author

PatrickfBraz commented Oct 6, 2023 •
edited
Loading

@chriscollins3456 @hsheth2
I think the PR is ready now. Sorry for the delay 😅

I'm already using this version in my environment and it's working correctly. I can share a print here in PR, if you find it relevant.

@jjoyce0510
Copy link
Collaborator

Im a bit nervous about completely removing GA3 - does Google still support it?

If google still supports, I'm in favor of supporting BOTH using different analytics providers on the UI.

Thoughts?

@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 18, 2023

Google analytics 3 has been fully sunset and no longer accepts events, so it should be fine

@hsheth2
Copy link
Collaborator

hsheth2 commented Dec 28, 2023

@PatrickfBraz one last thing here: could you add a note to docs/updating-datahub.md?

Other than that, this should be good to merge. Not sure why we've let it linger for so long - that's entirely our bad.

chriscollins3456
chriscollins3456 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! since google analytics 3 is fully sunsetted and they stopped accepting new data in july 2023, i think we're safe to merge this.

either no one must have been using ga3 with datahub or their analytics have been broken for a year.

I'll add an update to updating-datahub.md myself

@chriscollins3456 chriscollins3456 mentioned this pull request Apr 3, 2024
Merged
5 tasks
@MatMoore
Copy link

MatMoore commented Jun 17, 2024 •
edited
Loading

Hi @chriscollins3456 is there anything stopping this being merged? We'd also like to make use of GA4 and this PR looks like it does the job.

This was referenced Jun 17, 2024
Closed
Open
@chriscollins3456
Copy link
Collaborator

noticed some CI failures and just pushed up hopefully the final fix then will merge

@chriscollins3456 chriscollins3456 merged commit 6307eec into datahub-project:master Jun 24, 2024
35 of 36 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@PatrickfBraz @chriscollins3456 @sleeperdeep
feat(web-react): adds the possibility to track events through GA4 (da…
93eeefc 
…tahub-project#8231)

Co-authored-by: Chris Collins <[email protected]>
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@PatrickfBraz @chriscollins3456 @sleeperdeep
feat(web-react): adds the possibility to track events through GA4 (da…
acae6c6 
…tahub-project#8231)

Co-authored-by: Chris Collins <[email protected]>
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@PatrickfBraz @chriscollins3456 @yoonhyejin
feat(web-react): adds the possibility to track events through GA4 (#8231
4a1d046 
)

Co-authored-by: Chris Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees

@chriscollins3456 chriscollins3456

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PatrickfBraz @hsheth2 @jjoyce0510 @MatMoore @chriscollins3456 @anshbansal