feat(web-react): creates page to manage homepage posts #8292
Conversation
anshbansal
added
the
community-contribution
There was a problem hiding this comment.
nice! this is looking awesome - thank you so much for taking the time to do this!
The two main things I think that need to be done are:
- add a new platform permission for managing posts to control who can do this (and hide the tab in the UI if they can't)
- move the posts page from a button on the top to our Settings
| BUILD_PATH=build/yarn | ||
| MANAGE_POSTS_ENABLED=true |
There was a problem hiding this comment.
what we've been trying to do is to create feature flags that are more global and can be set with env variables in our helm charts. this involves setting it in application.yaml with a default (true in this case) and passing that feature flag to the frontend in our app config graphql endpoint. An example PR doing exactly this and disabling a piece of the UI based on the flag is here: #8067
There was a problem hiding this comment.
Hmmm Thanks @chriscollins3456 !!
| // const SuggestedNamesGroup = styled.div` | ||
| // margin-top: 12px; | ||
| // `; | ||
| // | ||
| // const ClickableTag = styled(Tag)` | ||
| // :hover { | ||
| // cursor: pointer; | ||
| // } | ||
| // `; |
There was a problem hiding this comment.
can you delete this commented out code?
| <LinkWrapper> | ||
| <Link to="/posts"> | ||
| <Button id="manage-posts-page" type="text"> | ||
| <Tooltip title="Manage home page posts"> | ||
| <NavTitleContainer> | ||
| <NotificationOutlined /> | ||
| <NavTitleText>News</NavTitleText> | ||
| </NavTitleContainer> | ||
| </Tooltip> | ||
| </Button> | ||
| </Link> | ||
| </LinkWrapper> |
There was a problem hiding this comment.
after talking with our designer we have some concerns with adding another button to the top header of the app. Instead, we suggest putting this in Settings under the left sidebar "Manage" section right underneath the new Ownership Types section. then we can render the homepage posts there in settings
| @@ -107,6 +110,20 @@ export function HeaderLinks(props: Props) { | |||
| </Link> | |||
| </LinkWrapper> | |||
| )} | |||
| {showManagePosts && ( | |||
There was a problem hiding this comment.
another thing we're going to need is a new permission for users to be able to manage these posts. So maybe a simple platform privilege MANAGE_POSTS or something. An example would be like MANAGE_GLOSSARIES privilege. This way datahub users can gate who is actually updating their home page with these posts - so that means some more java work as well
| /** | ||
| * Add an entry to the list posts cache. | ||
| */ | ||
| export const addToListPostCache = (client, newPost, pageSize) => { |
There was a problem hiding this comment.
thanks for building these cache updating functions!
| export function PostTitleColumn() { | ||
| return (record: PostEntry) => ( | ||
| <span data-testid={record.urn}> | ||
| <PostTitleContainer> | ||
| <Typography.Text>{record.title}</Typography.Text> | ||
| </PostTitleContainer> | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| export function PostDescriptionColumn() { | ||
| return (record: PostEntry) => ( | ||
| <span> | ||
| <PostTitleContainer> | ||
| <Typography.Text>{record.description}</Typography.Text> | ||
| </PostTitleContainer> | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| export function PostContentTypeColumn() { |
There was a problem hiding this comment.
all of these look pretty much the same except for the data-testid added - could we make this a singular generic function? we could pass in an optional dataTestId as a prop if we wanted that and only wanted that on one of the column titles
| export default function PostItemMenu({ title, urn, onDelete }: Props) { | ||
| const [deletePostMutation] = useDeletePostMutation(); | ||
|
|
||
| const deleteDomain = () => { |
There was a problem hiding this comment.
copy paste typo - should be deletePost
|
hey @PatrickfBraz thanks again for this! let me know if you want any assistance pushing this thing forward :) |
|
So we actually had a need to get this feature in sooner than expected so I ended up taking your work here and building off of it/finished things up in my PR here: #8707 Thank you so much for your hard work on this! it's going to be such a nice feature that people will love. |
|
Closing this PR as the work was done in another PR. Thanks for raising this. |
Context
Not long ago, the ads feature on the home page was added. It is an amazing feature to bring news to users. However, I believe that it has been very little explored due to the difficulties of managing the posts. The purpose of this PR is to aggregate everything already available in GraphQL in a page where users can more easily manage their posts on the home page.
Prints of the new page
New button (called "News") on homepage header to enter the Manage Posts page
Create new posts
Se your Posts
There is only option to delete your posts (yet..)
Confirming that the posts were created kkk
Caveats:
Checklist