Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): Do not override the search analyzer for ngram fields #8818

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

iprentic
Copy link
Contributor

@iprentic iprentic commented Sep 11, 2023

Using the same analyzer for the index and search is already the default: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-analyzer.html
By default, queries will use the analyzer defined in the field mapping

So, no need to specify it explicitly, and doing so causes the system update job to detect a difference between the field as exists in ES and the defined mapping when there isn't one.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 11, 2023
@david-leifker david-leifker added merge-pending-ci A PR that has passed review and should be merged once CI is green. release-0.11.0 platform PR-s that make changes to core parts of the platform and removed product PR or Issue related to the DataHub UI/UX labels Sep 11, 2023
@david-leifker david-leifker merged commit 1efc5d9 into master Sep 11, 2023
43 of 44 checks passed
@david-leifker david-leifker deleted the search-analyz branch September 11, 2023 16:31
iprentic added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-pending-ci A PR that has passed review and should be merged once CI is green. platform PR-s that make changes to core parts of the platform release-0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants