Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): use epoch 1 for dev build versions #8824

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(ingest): use epoch 1 for dev build versions #8824

merged 1 commit into from
Sep 12, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 12, 2023

Inspired by Dagster's approach to this problem, which is the exact same problem we're running into right now: dagster-io/dagster#11334

Superseeds #8816.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(ingest): use epoch 1 for dev build versions
f439ec3 
Inspired by Dagster's approach to this problem, which is the exact same
problem we're running into right now: dagster-io/dagster#11334

Superseeds datahub-project#8816.
@hsheth2 hsheth2 mentioned this pull request Sep 12, 2023
Closed
5 tasks
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Sep 12, 2023
asikowitz
asikowitz approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean solution

@hsheth2 hsheth2 merged commit f7fee74 into datahub-project:master Sep 12, 2023
59 checks passed
@hsheth2 hsheth2 deleted the dev-epoch branch September 12, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz