Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion): Add test_connection methods for important sources #9334

Merged
merged 12 commits into from
Dec 14, 2023
Merged

feat(ingestion): Add test_connection methods for important sources #9334

merged 12 commits into from
Dec 14, 2023

Conversation

shubhamjagtap639
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 29, 2023
hsheth2
hsheth2 reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some tests for some of these?

metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_core.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/postgres.py Outdated Show resolved Hide resolved
hsheth2
hsheth2 reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good, just a few small things on testing

metadata-ingestion/tests/unit/test_sql_common.py Show resolved Hide resolved
metadata-ingestion/tests/unit/test_sql_common.py Show resolved Hide resolved
metadata-ingestion/tests/integration/dbt/test_dbt.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/kafka/test_kafka.py Outdated Show resolved Hide resolved
hsheth2
hsheth2 approved these changes Dec 12, 2023
View reviewed changes
metadata-ingestion/tests/test_helpers/test_connection_helpers.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this stuff looks great

@shubhamjagtap639 shubhamjagtap639 marked this pull request as ready for review December 12, 2023 18:15
@hsheth2 hsheth2 merged commit 1741c07 into datahub-project:master Dec 14, 2023
53 checks passed
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@shubhamjagtap639 @Salman-Apptware
feat(ingestion): Add test_connection methods for important sources (d…
0565b26 
…atahub-project#9334)
@shubhamjagtap639 shubhamjagtap639 deleted the Add-test_connection-methods-for-important-sources branch March 14, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamjagtap639 @hsheth2