fix(powerbi): add access token refresh #9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
anshbansal
changed the title
hsheth2
approved these changes
Dec 8, 2023
hsheth2
added
the
merge-pending-ci
Powerbi returns an expiry time for the access token which is currently ignored. This causes all api calls to fail after 60 minutes, which is the timeout returned by PowerBI. This commit fixes the bug by creating a new token once the old one expires.
noggi
force-pushed
the
powerbi/fix-credentials-timeout
branch
from
52acf35
to
956d7ad
Compare
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
Co-authored-by: elish7lapid <[email protected]> Co-authored-by: treff7es <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating this PR #8680 to add token expiry fix
Checklist