Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(react): Fix typescript errors in test files #9982

Merged
merged 3 commits into from
Mar 6, 2024
Merged

build(react): Fix typescript errors in test files #9982

merged 3 commits into from
Mar 6, 2024

Conversation

sumitappt
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 5, 2024
@sumitappt
Copy link
Collaborator Author

Screenshot from 2024-03-05 20-47-45
Screenshot from 2024-03-05 20-25-13

@asikowitz asikowitz changed the title fix: OBS-564 | Fix typescript errors for tests in OSS build(react): Fix typescript errors in test files Mar 5, 2024
asikowitz
asikowitz reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very reasonable to me. I'm gonna look into the type casts a little + the entity profile test failure, and I have one question

datahub-web-react/src/app/lineage/types.ts
@@ -81,7 +81,7 @@ export type NodeData = {
canEditLineage?: boolean;
upstreamRelationships?: Array<LineageRelationship>;
downstreamRelationships?: Array<LineageRelationship>;
health?: Health[];
health?: Maybe<Health[]>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change necessary? Can we replace usage with health={health ?? undefined} or something like that instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, seems fine

@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 6, 2024
@asikowitz
Copy link
Collaborator

Merging before smoke tests finish as this should only be frontend test / types changes

@asikowitz asikowitz merged commit 3e31ae4 into datahub-project:master Mar 6, 2024
34 of 35 checks passed
dushayntAW pushed a commit to dushayntAW/datahub that referenced this pull request Mar 7, 2024
@sumitappt @asikowitz @dushayntAW
build(react): Fix typescript errors in test files (datahub-project#9982)
658086f 
Co-authored-by: Andrew Sikowitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumitappt @asikowitz