Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc-47182] GKE plugin: log API calls #22

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[sc-47182] GKE plugin: log API calls #22

wants to merge 1 commit into from

Conversation

amandineslx
Copy link
Contributor

@amandineslx amandineslx added this to the V 12.0.0 milestone Feb 2, 2023
@amandineslx amandineslx self-assigned this Feb 2, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #47182: GKE plugin: log API calls.

nikopol
nikopol approved these changes Feb 17, 2023
View reviewed changes
python-lib/dku_kube/role.py
else:
logging.info("Creating ClusterRoleBinding with KUBECONFIG=%s" % kube_config_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the kube config path is already log before, but I guess the repetition doesn't harm anyone ;)

@amandineslx
Copy link
Contributor Author

Putting this PR on hold until we decide what we want to do with it regarding [sc-105893]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #105893: [AKS/EKS/GKE] Identify and hide secrets in plugin logs.

@amandineslx amandineslx modified the milestones: V 12.0.0, V 12.1.0 Mar 17, 2023
@mhoarau mhoarau modified the milestones: V 12.1.0, V 12.2.0 May 11, 2023
@mhoarau mhoarau modified the milestones: V 12.2.0, V 12.3.0 Aug 3, 2023
@thtrunck thtrunck removed this from the V 12.4.0 milestone Mar 22, 2024
@thtrunck thtrunck marked this pull request as draft March 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jules-casoli jules-casoli jules-casoli approved these changes

@nikopol nikopol nikopol approved these changes

Assignees

@amandineslx amandineslx

Labels
on-hold on-perpetual-hold pending-work theme-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amandineslx @nikopol @jules-casoli @mhoarau @thtrunck