Skip to content

Commit

Permalink
Merge pull request #4 from dataiku/feature/dss12-sc-189489-rename-plu…
Browse files Browse the repository at this point in the history
…gin-components-prefix-with-plugin

Rename plugin components
  • Loading branch information
louisdorard committed Jun 19, 2024
2 parents 4e5b5eb + 6b30210 commit 263ddac
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions dss-plugin-visual-edit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ The code was developed in Python (environment specs are in `code-env/`) and is o
We recommend reading the components' descriptions, available on your Dataiku instance once you've installed the plugin.

* **`custom-recipes/` (Dataiku plugin components: Recipes)** leverage the data persistence layer and Custom Fields (see below) to replay edits found in an editlog dataset, and integrate them into a Dataiku Flow.
* **`custom-fields/edit-schema/` (Dataiku plugin component: Custom Fields)** provides a place to store dataset settings such as primary keys and editable columns, which are used by the Recipes. Currently, these settings are duplicated across the original dataset and the editlog:
* **`custom-fields/visual-edit-schema/` (Dataiku plugin component: Custom Fields)** provides a place to store dataset settings such as primary keys and editable columns, which are used by the Recipes. Currently, these settings are duplicated across the original dataset and the editlog:
* original dataset:
* `primary_keys` is used by the Apply Edits function/recipe, which joins the original and edits datasets
* `editable_columns` is used to present columns in a certain order
* Note: both properties are returned by the `get_original_df()` method in `commons.py`.
* editlog dataset:
* `primary_keys` is used by the Replay Edits function/recipe to unpack key values into 1 column per primary key and to figure out key names.
* **`python-steps/empty-editlog/` (Dataiku plugin component: Scenario step)** empties the editlog by deleting all rows (this is only used for testing purposes on a design instance).
* **`python-steps/visual-edit-empty-editlog/` (Dataiku plugin component: Scenario step)** empties the editlog by deleting all rows (this is only used for testing purposes on a design instance).

### Dash Webapp

Expand Down
2 changes: 1 addition & 1 deletion dss-plugin-visual-edit/plugin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "visual-edit",
"version": "2.0.0",
"version": "2.0.1",
"meta": {
"label": "Visual Edit",
"description": "Build apps to validate and edit data within pipelines",
Expand Down
4 changes: 2 additions & 2 deletions dss-plugin-visual-edit/python-lib/DataEditor.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def __setup_editlog_downstream__(self):

replay_recipe_name = "compute_" + self.edits_ds_name
replay_recipe_creator = DSSRecipeCreator(
"CustomCode_replay-edits", replay_recipe_name, self.project
"CustomCode_visual-edit-replay-edits", replay_recipe_name, self.project
)
if recipe_already_exists(replay_recipe_name, self.project):
logging.debug("Found recipe to create edits dataset")
Expand Down Expand Up @@ -149,7 +149,7 @@ def __setup_editlog_downstream__(self):

apply_recipe_name = "compute_" + self.edited_ds_name
apply_recipe_creator = DSSRecipeCreator(
"CustomCode_apply-edits", apply_recipe_name, self.project
"CustomCode_visual-edit-apply-edits", apply_recipe_name, self.project
)
if recipe_already_exists(apply_recipe_name, self.project):
logging.debug("Found recipe to create edited dataset")
Expand Down

0 comments on commit 263ddac

Please sign in to comment.