Fix electrode index on units table #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
electrodescolumn of theUnitstable expects a list of 0-indexed values corresponding to the rows of the electrodes table. Sinceunit[electrode]is 1-indexed, 1 should be subtracted from that value to get the corresponding 0-indexed row in the electrodes table.This could be made more explicit when this convenience function gets released: hdmf-dev/hdmf#187 . You could then use this line:
electrodes=nwbfile.electrodes[ nwbfile.electrodes.id == unit['electrode']],This is a critical bug because currently all files have all units that reference the wrong electrode metadata, and several files, such as ANM255201_2014-11-23_4.nwb, cannot be read.