Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete date/time format conversion fix, update primary field css #105

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

mahos
Copy link
Contributor

@mahos mahos commented Mar 1, 2021

  • make sure selected entries with date/time as primary field get converted correctly in delete mode.
    Screenshot Mar-02-2021 11-14-22

  • update css for update mode where primary field doesn't look like it's editable.
    screenshot Mar-02-2021 11-18-47

@mahos mahos added the bug Something isn't working label Mar 2, 2021
@mahos mahos marked this pull request as ready for review March 2, 2021 00:45
Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahos Please also add some screenshots demonstrating the visual changes and update the Milestone assignment on this PR.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
mahos and others added 2 commits March 2, 2021 11:19
Co-authored-by: Raphael Guzman <[email protected]>
Co-authored-by: Raphael Guzman <[email protected]>
@mahos mahos added this to the Official Release milestone Mar 2, 2021
@guzman-raphael guzman-raphael merged commit 12f179e into datajoint:dev Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants