-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pageination rewrite #117
Pageination rewrite #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Synicix Also update the GH Project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it and I think it works as expected - one thing I noticed is how the filter gets reset when I update the rows/page number but the card is still there - though I think that's more of an issue to be dealt with on the filter side and not this pagination implementation.
Hmm those two shouldn't be affected... I look into it |
Found the issue, I need to work on a fix for this. Putting this as draft till fix is completed. Thanks for catching this @mahos |
Okay I redesign the filter handling, that should fix the issue now. @mahos |
Depends on #106