Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pageination rewrite #117

Merged
merged 13 commits into from
Mar 8, 2021
Merged

Pageination rewrite #117

merged 13 commits into from
Mar 8, 2021

Conversation

Synicix
Copy link
Contributor

@Synicix Synicix commented Mar 4, 2021

Depends on #106

  • Pagenation now works properly and no longer fetches the entire table which is extremely wasteful
  • Switching between tablecontent and tableinfo now doens't trigger a fetch if there is no need to
  • Added a input field for how many tuples the user wants to display on their screen (default is still 25)
  • Some code clean up such as removing unecessary copys of props to state when the variables can just be used from props directly

image
image

@Synicix Synicix marked this pull request as draft March 4, 2021 22:39
@Synicix Synicix added the enhancement New feature or request label Mar 4, 2021
@Synicix Synicix added this to the Official Release milestone Mar 4, 2021
@Synicix Synicix linked an issue Mar 4, 2021 that may be closed by this pull request
@Synicix
Copy link
Contributor Author

Synicix commented Mar 4, 2021

Added max page to the viewer:
image

@Synicix Synicix marked this pull request as ready for review March 4, 2021 23:21
@Synicix Synicix requested review from mahos and guzman-raphael and removed request for mahos March 4, 2021 23:27
Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Synicix Also update the GH Project.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/Components/MainTableView/TableContent.tsx Outdated Show resolved Hide resolved
src/Components/MainTableView/TableContent.tsx Show resolved Hide resolved
src/Components/MainTableView/TableView.tsx Outdated Show resolved Hide resolved
src/Components/MainTableView/TableView.tsx Outdated Show resolved Hide resolved
mahos
mahos previously approved these changes Mar 6, 2021
Copy link
Contributor

@mahos mahos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it and I think it works as expected - one thing I noticed is how the filter gets reset when I update the rows/page number but the card is still there - though I think that's more of an issue to be dealt with on the filter side and not this pagination implementation.

@Synicix
Copy link
Contributor Author

Synicix commented Mar 8, 2021

I tried it and I think it works as expected - one thing I noticed is how the filter gets reset when I update the rows/page number but the card is still there - though I think that's more of an issue to be dealt with on the filter side and not this pagination implementation.

Hmm those two shouldn't be affected... I look into it

@Synicix
Copy link
Contributor Author

Synicix commented Mar 8, 2021

Found the issue, I need to work on a fix for this. Putting this as draft till fix is completed. Thanks for catching this @mahos

@Synicix Synicix marked this pull request as draft March 8, 2021 15:24
@Synicix
Copy link
Contributor Author

Synicix commented Mar 8, 2021

Okay I redesign the filter handling, that should fix the issue now. @mahos

@Synicix Synicix marked this pull request as ready for review March 8, 2021 15:47
@Synicix Synicix requested a review from mahos March 8, 2021 15:47
mahos
mahos previously approved these changes Mar 8, 2021
@guzman-raphael guzman-raphael merged commit 5cc8803 into datajoint:dev Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite pagination logic
3 participants