Add loading animations #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synicix
reviewed
Mar 8, 2021
| </div> | ||
| ) | ||
| })} | ||
|
|
| <div className="tableNameSkeleton"></div> | ||
| </div> | ||
| ) | ||
| })} |
There was a problem hiding this comment.
I think that last } should be maybe be on a new line?
Comment on lines
24
to
27
| FILTER = 'Filter', | ||
| INSERT = 'Insert', | ||
| UPDATE = 'Update', | ||
| DELETE = 'Delete' |
There was a problem hiding this comment.
Try to keep this as default autoincrement intergers cause that is vastly more efficeint then comparing strings.
If you want to get the strings, you can write a quick function to if and else the enum then return a string.
| @@ -530,7 +531,8 @@ class TableView extends React.Component<{token: string, selectedSchemaName: stri | |||
| } else { | |||
| return ( | |||
| <div className="loadingArea"> | |||
| <div className="loadingMessage">Loading...</div> | |||
| <BasicLoadingIcon size={100} /> | |||
| {/* <div className="loadingMessage">Loading...</div> */} | |||
Synicix
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
add loading animation while waiting for table list
add loading animation while waiting for table content
add animation while waiting for table action (insert/update/delete)
