Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layout smaller screen size friendly #127

Merged
merged 15 commits into from
Mar 17, 2021
Merged

Make layout smaller screen size friendly #127

merged 15 commits into from
Mar 17, 2021

Conversation

mahos
Copy link
Contributor

@mahos mahos commented Mar 15, 2021

Make column size fit either the header or the body content - whichever is larger and also make the columns resizable.
fixes #11
resize column 1

Make layout change for smaller screens (still in works)
fixes #58
labbook resize

@mahos mahos marked this pull request as ready for review March 16, 2021 02:50
src/Components/MainTableView/TableContent.tsx Outdated Show resolved Hide resolved
src/Components/MainTableView/TableContent.tsx Outdated Show resolved Hide resolved
src/Components/MainTableView/TableContent.tsx Outdated Show resolved Hide resolved
@guzman-raphael
Copy link
Collaborator

@mahos Would you also assign this PR to a Milestone?

@mahos mahos added this to the Official Release milestone Mar 16, 2021
guzman-raphael
guzman-raphael previously approved these changes Mar 16, 2021
Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahos Good from my side. Will give @Synicix an opportunity to give a last look and go ahead with merge.

Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one syntax change

src/Components/MainTableView/TableContent.tsx Outdated Show resolved Hide resolved
@Synicix Synicix merged commit 1cdd098 into datajoint:dev Mar 17, 2021
@Synicix Synicix linked an issue Mar 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants