Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_object failure should be exception, not error return value #952

Closed
chrisroat opened this issue Aug 27, 2021 · 1 comment · Fixed by #955
Closed

remove_object failure should be exception, not error return value #952

chrisroat opened this issue Aug 27, 2021 · 1 comment · Fixed by #955

Comments

@chrisroat
Copy link
Contributor

Should this return be a raise?

return errors.DataJointError('Failed to delete %s from s3 storage' % name)

@chrisroat chrisroat reopened this Aug 27, 2021
@guzman-raphael
Copy link
Collaborator

@chrisroat Thanks for reviewing this! It does appear that it would make more sense for this to raise an error. I'll mark it as a bug for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment