Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-161: Migrate test_reconnection #1133

Merged
merged 4 commits into from
Dec 13, 2023
Merged

PLAT-161: Migrate test_reconnection #1133

merged 4 commits into from
Dec 13, 2023

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Dec 13, 2023

  • No changes from previous PRs. This branch was forked directly from dev-tests.
  • cp to tests
  • nose2pytest test_reconnection
  • Migrate test_reconnection

@ethho
Copy link
Contributor Author

ethho commented Dec 13, 2023 •
edited
Loading

CI failed due to non-deterministic test tests/test_blob.py::test_datetime_serialization_speed, which is a known issue and is scoped for fixing in PLAT-171.

@ethho ethho marked this pull request as ready for review December 13, 2023 18:24
@ethho ethho requested a review from A-Baji December 13, 2023 18:24
@ethho
Copy link
Contributor Author

ethho commented Dec 13, 2023

Re-ran and passed CI with python3.8

@A-Baji A-Baji mentioned this pull request Dec 13, 2023
Merged
@A-Baji A-Baji merged commit 46a015c into datajoint:dev-tests Dec 13, 2023
9 checks passed
This was referenced Dec 15, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Baji A-Baji A-Baji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethho @A-Baji