Fix #698 and #699 #706
Merged
Fix #698 and #699 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dimitri-yatsenko
commented
Nov 19, 2019
•
dimitri-yatsenko
commented
- Fix help does not work on tables #698 -- Help now works for DataJoint classes
- Fix Append table definition to docstring #699 -- table definition is appended to doc string
ixcat
approved these changes
Nov 21, 2019
tests/test_relation.py
Outdated
| @@ -36,6 +36,12 @@ def setup_class(cls): | |||
| cls.img = schema.Image() | |||
| cls.trash = schema.UberTrash() | |||
|
|
|||
| def test_class_help(self): | |||
| help(schema.TTest) | |||
There was a problem hiding this comment.
would it make sense to also e.g.:
assert schema.TTest.definition in schema.TTest.__doc__
There was a problem hiding this comment.
done. Also moved into test_declare
tests/test_relation.py
Outdated
| def test_class_help(self): | ||
| help(schema.TTest) | ||
|
|
||
| def test_instance_help(self): |
There was a problem hiding this comment.
as before r.e. testing for definition in doc.
There was a problem hiding this comment.
done. Also moved into test_declare
guzman-raphael
requested changes
Nov 21, 2019
|
@dimitri-yatsenko Can you also update |
datajoint/blob.py
Outdated
| @@ -253,6 +253,9 @@ def pack_recarray(self, array): | |||
| def read_sparse_array(self): | |||
| raise DataJointError('datajoint-python does not yet support sparse arrays. Issue (#590)') | |||
|
|
|||
| def read_scalar(selfs): | |||
|
|
|||
There was a problem hiding this comment.
This looks like a typo... Does not raise/return anything?
guzman-raphael
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.