Rename dj.schema to dj.Schema and dj.create_virtual_module to dj.VirtualModule #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as.py, and make VirtualModule a proper class.
dimitri-yatsenko
requested changes
Feb 10, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| ## Release notes | |||
|
|
|||
| ### 0.12.5 -- Feb TBA, 2020 | |||
| * `dj.schema` is now called `dj.Schema` (#731) PR #732 | |||
There was a problem hiding this comment.
Suggested change
| * `dj.schema` is now called `dj.Schema` (#731) PR #732 | |
| * Renamed module `dj.schema` into `dj.schemas`. `dj.schema` remains an alias for the class `dj.Schema`. (#731) PR #732 |
datajoint/__init__.py
Outdated
| @@ -18,7 +18,7 @@ | |||
| __date__ = "February 7, 2019" | |||
| __all__ = ['__author__', '__version__', | |||
| 'config', 'conn', 'Connection', | |||
| 'schema', 'create_virtual_module', 'list_schemas', | |||
| 'Schema', 'VirtualModule', 'list_schemas', | |||
There was a problem hiding this comment.
Suggested change
| 'Schema', 'VirtualModule', 'list_schemas', | |
| 'Schema', 'schema', 'VirtualModule', 'create_virtual_module', 'list_schemas', |
dimitri-yatsenko
approved these changes
Feb 11, 2020
dimitri-yatsenko
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #731
Update tests such that database is behind NGINX reverse-proxy.