Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify _update to allow nullable updates for strings/date #760

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

guzman-raphael
Copy link
Collaborator

Fix #664

@dimitri-yatsenko
Copy link
Member

dimitri-yatsenko commented Apr 14, 2020

Let's talk about this briefly. I am preparing an alternative solution that uses the full functionality of insert for a new update. This fixes other issues such as, for example, updating external values. While the solution in this PR addresses the issue, the forthcoming new feature will fix this and all other issues with update. We may choose to keep _update for continuity but will likely remove it in future versions.

@dimitri-yatsenko
Copy link
Member

Would you please merge #757? Then it's good to go.

@neuralsignal
Copy link
Contributor

On my fork I implemented a new update that uses the functionality of insert. The new update function I wrote also prohibits updating of entries with autopopulated dependent entries (this behavior can also be suppressed). Please, let me know if this is of general interest.

@guzman-raphael
Copy link
Collaborator Author

Awesome stuff, @gucky92! We have also been working on this with a PR to address it imminent. @dimitri-yatsenko can you update if the new update1 will have features mentioned above?

@eywalker eywalker merged commit 9fec9d4 into datajoint:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update back to null does not work for date or datetime
4 participants