Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method update1 to dj.Table #763

Merged
merged 8 commits into from
May 8, 2020
Merged

add method update1 to dj.Table #763

merged 8 commits into from
May 8, 2020

Conversation

dimitri-yatsenko
Copy link
Member

Implement Table.update1 that works similarly to insert1, updating specified secondary attributes.

@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review April 17, 2020 05:17
@guzman-raphael guzman-raphael self-requested a review April 20, 2020 13:21
guzman-raphael
guzman-raphael requested changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you add a filepath test? Say if the user want to modify a tracked file? Also, since this is not slated for the next 0.12.6 release, can you target a feature branch?

@dimitri-yatsenko dimitri-yatsenko changed the base branch from master to release013 April 24, 2020 23:43
@dimitri-yatsenko
Copy link
Member Author

@guzman-raphael Your review comment has been addressed.

@guzman-raphael guzman-raphael merged commit ec5668b into datajoint:release013 May 8, 2020
@dimitri-yatsenko dimitri-yatsenko deleted the update1 branch September 25, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guzman-raphael guzman-raphael guzman-raphael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitri-yatsenko @guzman-raphael