Cascade delete and deferred schemas #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `test_same_secondary_attribute` test + PR review feedback
Fix join error in the new query parser (datajoint#857)
…e to long, complex foreign keys.
|
@dimitri-yatsenko Regarding issues #883 and #886, I believe this PR is the best place to properly address them. To assist with this, I will soon open a PR to your fork/branch with the fix. |
Fix error when cascading delete on tables with many, complex keys
This was
linked to
issues
Mar 22, 2021
Closed
guzman-raphael
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
@dimitri-yatsenko Whew, and we are finally ready to merge this one. Awesome collaborating with you here!
I approve the changes though there are still a few small remaining items before I'd say we are clear to release. Planning on issuing a PR soon to close out what remains.
To summarize it is:
- Add deprecation warning on
_update - Remove use of
from Nonewhen raised instances ofDataJointError - Add to docstring the operator reference for overloaded operators
- Add
purge_query_cachemethod - Add test for query caching
- Add tests for permissive restrictions and joins
- Move
transpiler_specs.mddocumentation to our proper documentation - Integrate QueryCache and Update1 docs into proper documentation
- Adjust version properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dj.Uwith aggregation result leads to incorrect result #449, Slow query due to subquery wrapping #450, aggr error #484, Projection removes antijoin constraints #558, set 0.12 'enable_python_native_blobs' check to True #761, Operators Join@and Restrict^with permissive join-compatibility checks. #785 (inherited from closed PR Aggr fix #754)