Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of numpy aliases of built-in types with built-in type #939

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 5, 2021

Fix #938.

Numpy 1.20 deprecated the use of numpy aliases of built-in types. Replacing the aliases with the built-in types does not change behavior but will silence the deprecation warning.
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Numpy 1.20 deprecated the use of numpy aliases of built-in types. 
Replacing the aliases with the built-in types does not change behavior 
but will silence the deprecation warning. 
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
@guzman-raphael
Copy link
Collaborator

@rly Thanks for the PR! Looks like the tests failed because the LetsEncrypt cert has expired. Would you mind updating all mentions of datajoint/nginx:v0.0.16 to datajoint/nginx:v0.0.17? The latest image should have the updated cert.

@guzman-raphael
Copy link
Collaborator

@rly Awesome. Change looks good. If you would just update the changelog we should be then ready for a merge. Could you add an entry to the changelog under 0.13.3 in the following 2 places? The date used there seems to be incorrect so you can simply put TBD for now.

Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for the PR! 🤝

@guzman-raphael guzman-raphael merged commit 5b81247 into datajoint:master Aug 9, 2021
@rly rly deleted the fix/np_deprecations branch August 9, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated use of numpy aliases of built-in types
2 participants