Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic bug in external file clean up #956

Merged
merged 19 commits into from
Sep 14, 2021
Merged

Fix logic bug in external file clean up #956

merged 19 commits into from
Sep 14, 2021

Commits on Aug 31, 2021

  1. add test placeholder.

    Carlos Ortiz authored and Carlos Ortiz committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    4a64615 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Add test file to see file location and permissions.

    Carlos Ortiz authored and Carlos Ortiz committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f41b8d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Added new print statements and added new print statements within exte… 

    …rnal.py
    Carlos Ortiz authored and Carlos Ortiz committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    ad32b6e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. adding more asserts to test file

    Carlos Ortiz authored and Carlos Ortiz committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    7b3600a View commit details
    Browse the repository at this point in the history

  2. adding new func to delete in external.py

    Carlos Ortiz authored and Carlos Ortiz committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    e244337 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. added code to test

    Carlos Ortiz authored and Carlos Ortiz committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6452838 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Uncomment to re-enable test

    @zitrosolrac
    zitrosolrac committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e0bd234 View commit details
    Browse the repository at this point in the history

  2. Update lnx-docker and local-docker files with correct version of image

    @zitrosolrac
    zitrosolrac committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8558adb View commit details
    Browse the repository at this point in the history

  3. Fix issues with style tests in external.py

    @zitrosolrac
    zitrosolrac committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    56cf8b7 View commit details
    Browse the repository at this point in the history

  4. Remove print statements

    @zitrosolrac
    zitrosolrac committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    84e4aa4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Ignore FileNotFound Exception when deleting, optimize external table … 

    …delete method, and re write test_removal_fail
    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5aa9b1e View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG and DOCS-PART

    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    957c563 View commit details
    Browse the repository at this point in the history

  3. Merging changes from master

    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b15fe43 View commit details
    Browse the repository at this point in the history

  4. Update tests/test_external.py 

    Co-authored-by: Raphael Guzman <[email protected]>
    @zitrosolrac @guzman-raphael
    zitrosolrac and guzman-raphael authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    cdae1d5 View commit details
    Browse the repository at this point in the history

  5. Fixed parenthesis issue and uncommented logging console.

    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    554fc71 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'external_removal_fail' of https://github.com/zitrosolra… 

    …c/datajoint-python into external_removal_fail
    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    f3436f0 View commit details
    Browse the repository at this point in the history

  7. Fix return statement placement

    @zitrosolrac
    zitrosolrac committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    d4b972f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Update datajoint/external.py 

    Co-authored-by: Raphael Guzman <[email protected]>
    @zitrosolrac @guzman-raphael
    zitrosolrac and guzman-raphael authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    f8e8196 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge branch 'master' into external_removal_fail

    @dimitri-yatsenko
    dimitri-yatsenko authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    707953b View commit details
    Browse the repository at this point in the history