Fix #930 union join bug, Add test for union join. #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 0.13.2 we are improperly forming the sql query when we perform a union and then a join, below are the
make_sql()
's comparing 0.13.2 to 0.12.9:Below is the
make_sql
after I added code to fix itI think this solution is good but I have included all the
make_sql()
's to ensure that my solution did not introduce any unintended consequences.fix #930