-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 3.10 and allow renaming attributes in proj even if they do not follow datajoint naming conventions. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dimitri-yatsenko
commented
Nov 11, 2021
•
edited
Loading
edited
- Fix Fix renaming non DataJoint attributes using proj #982
- Fix Python 3.10 error. AttributeError: module 'collections' has no attribute 'MutableMapping' #983
…tside datajoint naming conventions
This fix is related to this conversation in Slack. |
Fix renaming attributes
guzman-raphael
requested changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimitri-yatsenko Looks good! 🤝
Would you just update CHANGELOG.md
and docs-parts/intro/Releases_lang1.rst
with the fix?
dimitri-yatsenko
changed the title
Allow renaming attributes in proj even if they do not follow datajoint naming conventions.
Fix Python 3.10 and allow renaming attributes in proj even if they do not follow datajoint naming conventions.
Jan 19, 2022
guzman-raphael
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.