Better handle case where block in database is not implemented by app/API

datalab-org · Oct 15, 2024 · 4054f52 · 4054f52
1 parent 389eae1
commit 4054f52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/webapp/src/components/datablocks/DataBlockBase.vue b/webapp/src/components/datablocks/DataBlockBase.vue
@@ -9,7 +9,9 @@
       />
       <input v-model="BlockTitle" class="form-control-plaintext block-title" type="text" />
       <span class="blocktype-label ml-auto mr-3">{{ blockType }}</span>
-      <span class="block-header-icon"><StyledBlockInfo :block-info="blockInfo" /></span>
+      <span v-if="blockInfo" class="block-header-icon"
+        ><StyledBlockInfo :block-info="blockInfo"
+      /></span>
       <font-awesome-icon
         :icon="['fa', 'sync']"
         class="block-header-icon"
@@ -170,7 +172,7 @@ export default {
       return this.$store.state.updatingDelayed[this.block_id];
     },
     blockInfo() {
-      return this.$store.state.blocksInfos[this.blockType];
+      return this.$store.state.blocksInfos?.[this.blockType];
     },
     BlockTitle: createComputedSetterForBlockField("title"),
     BlockDescription: createComputedSetterForBlockField("freeform_comment"),

diff --git a/webapp/src/components/datablocks/NotImplementedBlock.vue b/webapp/src/components/datablocks/NotImplementedBlock.vue
@@ -1,6 +1,9 @@
 <template>
   <DataBlockBase>
-    <div class="alert alert-danger">This block type has not been implemented!</div>
+    <div class="alert alert-danger">
+      This block type is not implemented/installed for this <i>datalab</i> instance. Please contact
+      your <i>datalab</i> administrator.
+    </div>
   </DataBlockBase>
 </template>