Repackage server as proper Python package, removing pipenv
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 66.89% 67.26% +0.37%
==========================================
Files 62 62
Lines 3727 3748 +21
==========================================
+ Hits 2493 2521 +28
+ Misses 1234 1227 -7
|
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
2 times, most recently
from
771d2fd
to
317dffd
Compare
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
from
a9bc3ec
to
5d6a0c7
Compare
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
3 times, most recently
from
5e6c1ad
to
0fe4bb8
Compare
|
Decision is to merge this PR immediately after the next release, to avoid breaking deployments. |
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
from
22d4ed9
to
d3ece3c
Compare
ml-evs
commented
Jul 30, 2024
- Update docs build configuration
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
from
bb3f114
to
b122a0e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 68.09% 68.10% +0.01%
==========================================
Files 62 62
Lines 3880 3882 +2
==========================================
+ Hits 2642 2644 +2
Misses 1238 1238
|
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
3 times, most recently
from
b6100af
to
11f7051
Compare
Remove .env from dockerignore Force recreate containers Debug print env Debug env Add app healthcheck
- More cleaning of dependencies - Add missing dep and fix package name in version finder - Add chat deps as an extra - Add pip-compile style lockfiles generated by uv - Update lock files - Tweak navani dep Use uv for docker builds and reintroduce hot-reload in dev container after flask update Resync pip compile and pyproject
Fix RTD
- Switch to setuptool-scm instead of versioningit, bump dotenv - Reinstate dotenv loading for non-config options
ml-evs
force-pushed
the
ml-evs/update-pyproject
branch
from
87517af
to
ddd27d7
Compare
ml-evs
added
documentation
ml-evs
changed the title
pipenv
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #582 and addresses #168
Moves around some config files and expands
pyprojectto be the single source of truth, with a dynamic version from the git tags. Also hacks the docker build so that this version info gets passed in production, and switches to usinguvinside the docker builds.For now, I'd like this PR to retain
PipfileandPipfile.lockso that existing developer workflows should still work. In the future, we will switch to purely usinguv-generated lockfiles for dependencies, which will allow us to use dependabot again properly, and make our dependency management less fraught with issues when wanting to update only one dep.Warning: the deps in
Pipfile.lockwill not exactly match theuvgenerated lock files.