Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple component test for ChemFormInput #743

Merged
merged 12 commits into from
Jul 30, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 17, 2024

Just testing this out for now, but otherwise could be useful for the development of #634 & #208

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (0869924) to head (c8665e9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files          62       62           
  Lines        3747     3747           
=======================================
  Hits         2520     2520           
  Misses       1227     1227           

Copy link

cypress bot commented May 17, 2024



Test summary

1 0 0 0


Run details

Project datalab
Status Passed
Commit f0aa7dd ℹ️
Started Jul 30, 2024 9:33 AM
Ended Jul 30, 2024 9:33 AM
Duration 00:04 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@ml-evs ml-evs changed the title Add simple compenent test for ChemFormInput Add simple component test for ChemFormInput May 31, 2024
@ml-evs ml-evs added the testing For issues/PRs that change how the package is tested label May 31, 2024
@ml-evs ml-evs mentioned this pull request Jul 3, 2024
@BenjaminCharmes BenjaminCharmes self-assigned this Jul 29, 2024
@BenjaminCharmes
Copy link
Contributor

BenjaminCharmes commented Jul 29, 2024

I fixed the cypress tests on the components. It should work now.

For this particular test, this still doesn't work because:

  • By default, “editable” is set to false, so the input does not appear when cypress mounts the component.
  • Chemical formulas don't format properly ("Na3" stay as "Na3" and not "Na3")

@ml-evs ml-evs force-pushed the ml-evs/chemform-component-test branch from eefab2d to 601b4c8 Compare July 29, 2024 16:53
@ml-evs
Copy link
Member Author

ml-evs commented Jul 29, 2024

Hmmm, not sure if I broke this again @BenjaminCharmes with my rebase + changes! I was just trying to get it to also show the e2e test results in GitHub again, but now the tests are back to failing because the component is not displayed. Perhaps you could work some magic again when you get a moment?

@ml-evs ml-evs force-pushed the ml-evs/chemform-component-test branch from e5c53be to d1ee9cc Compare July 30, 2024 09:26
@ml-evs ml-evs marked this pull request as ready for review July 30, 2024 09:26
@ml-evs ml-evs requested a review from jdbocarsly as a code owner July 30, 2024 09:26
@ml-evs ml-evs merged commit 489d3c9 into main Jul 30, 2024
8 checks passed
@ml-evs ml-evs deleted the ml-evs/chemform-component-test branch July 30, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing For issues/PRs that change how the package is tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants