Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run vue3-recommended linting #756

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Run vue3-recommended linting #756

merged 9 commits into from
Jun 19, 2024

Conversation

jdbocarsly
Copy link
Member

@jdbocarsly jdbocarsly commented Jun 3, 2024

Closes #45.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (43764fb) to head (de8a405).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files          62       62           
  Lines        3828     3828           
=======================================
  Hits         2571     2571           
  Misses       1257     1257           

Copy link

cypress bot commented Jun 3, 2024

Passing run #1937 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge de8a405 into 43764fb...
Project: datalab Commit: e9ecbf4fcf ℹ️
Status: Passed Duration: 02:06 💡
Started: Jun 19, 2024 1:28 PM Ended: Jun 19, 2024 1:30 PM

Review all test suite changes for PR #756 ↗︎

@BenjaminCharmes
Copy link
Contributor

I rebase main to retrieve the docker-compose changes.

For the moment I've deactivated 4 rules:

  • "vue/prop-name-casing"
  • "vue/require-default-prop"
  • "vue/require-prop-types"
  • "vue/v-on-event-hyphenation"

And dealt with the other problems case-by-case. I'm going to spend a little more time on it to make sure it all works. If you'd like me to reactivate any of the rules and fix the problems so that the errors don't trigger again, let me know.

@BenjaminCharmes
Copy link
Contributor

pre-commit.ci autofix

ml-evs
ml-evs previously approved these changes Jun 19, 2024
ml-evs
ml-evs previously approved these changes Jun 19, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminCharmes (and to a much lesser extent @jdbocarsly :P)

@ml-evs ml-evs enabled auto-merge (rebase) June 19, 2024 13:17
@ml-evs ml-evs disabled auto-merge June 19, 2024 13:43
@ml-evs
Copy link
Member

ml-evs commented Jun 19, 2024

PR is failing for some weird transient mypy reason, lets not hold this up and hope that we can fix it elsewhere

@ml-evs ml-evs merged commit c100de6 into main Jun 19, 2024
10 of 11 checks passed
@ml-evs ml-evs deleted the jdb/upgrade-eslint branch June 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling stricter JS linting for the webapp
3 participants