-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run vue3-recommended linting #756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 62 62
Lines 3828 3828
=======================================
Hits 2571 2571
Misses 1257 1257 |
Passing run #1937 ↗︎
Details:
Review all test suite changes for PR #756 ↗︎ |
I rebase main to retrieve the docker-compose changes. For the moment I've deactivated 4 rules:
And dealt with the other problems case-by-case. I'm going to spend a little more time on it to make sure it all works. If you'd like me to reactivate any of the rules and fix the problems so that the errors don't trigger again, let me know. |
pre-commit.ci autofix |
- Remove console.log for testing
b9289ae
to
7c7d68f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BenjaminCharmes (and to a much lesser extent @jdbocarsly :P)
a8a3422
to
de8a405
Compare
PR is failing for some weird transient mypy reason, lets not hold this up and hope that we can fix it elsewhere |
Closes #45.