Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs formatting and update versioning scheme #850

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 20, 2024

The setup-tools-scm version was not being picked up outside of docker as the .git folder is one level up. This PR fixes that, adds a simple test, and also makes some docs formatting fixes.

Copy link

cypress bot commented Aug 20, 2024



Test summary

132 0 0 0


Run details

Project datalab
Status Passed
Commit 113173b ℹ️
Started Aug 20, 2024 12:32 PM
Ended Aug 20, 2024 12:37 PM
Duration 05:24 💡
OS Linux Ubuntu -
Browser Multiple

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (4f43ccb) to head (7c382a1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   68.10%   68.12%   +0.01%     
==========================================
  Files          62       62              
  Lines        3882     3884       +2     
==========================================
+ Hits         2644     2646       +2     
  Misses       1238     1238              
Files Coverage Δ
pydatalab/pydatalab/main.py 65.92% <100.00%> (+0.51%) ⬆️

@ml-evs ml-evs force-pushed the ml-evs/docs-and-version-fixes branch 2 times, most recently from 17eb0b0 to e93891c Compare August 20, 2024 11:59
…n number

- Mount .git directory one level higher in docker build so that version gets picked up

- Mount .git directory in dev api container

- More version tweaks

- Set fetch-depth to 0 for pytest
@ml-evs ml-evs force-pushed the ml-evs/docs-and-version-fixes branch from e93891c to 7c382a1 Compare August 20, 2024 12:29
@ml-evs ml-evs merged commit baff653 into main Aug 20, 2024
17 checks passed
@ml-evs ml-evs deleted the ml-evs/docs-and-version-fixes branch August 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant