Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node v20 in build, CI and dev environments #858

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 23, 2024

Some deps now need node v20+, which we have always recommended anyway. This PR updates our docker, CI and dev envs to use node 20.

@ml-evs ml-evs changed the title Use node v20 in CI and dev environments Use node v20 in build, CI and dev environments Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (bc5399f) to head (065d1a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          62       62           
  Lines        3884     3884           
=======================================
  Hits         2646     2646           
  Misses       1238     1238           

Copy link

cypress bot commented Aug 23, 2024

datalab    Run #2325

Run Properties:  status check passed Passed #2325  •  git commit fb8155608f ℹ️: Merge 065d1a9c455100ce65c2a7f4fa30e54751e54454 into bc5399f46757fc6d764eb3eb386f...
Project datalab
Branch Review ml-evs/bump-node
Run status status check passed Passed #2325
Run duration 04m 52s
Commit git commit fb8155608f ℹ️: Merge 065d1a9c455100ce65c2a7f4fa30e54751e54454 into bc5399f46757fc6d764eb3eb386f...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@ml-evs ml-evs enabled auto-merge (squash) August 24, 2024 10:11
@ml-evs ml-evs disabled auto-merge August 24, 2024 10:11
@ml-evs ml-evs merged commit 264debe into main Aug 24, 2024
19 checks passed
@ml-evs ml-evs deleted the ml-evs/bump-node branch August 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant