Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues in the datatable #888

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Fix some issues in the datatable #888

merged 4 commits into from
Sep 27, 2024

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 25, 2024 •
edited by ml-evs
Loading

  • The functionality of adding to a collection from the 'Create New Item' modal has been verified and is working as intended
  • The issue of requiring each individual checkbox to be clicked precisely has been resolved by changing the click event to be triggered on the entire cell instead of just the checkbox
  • The "select all" button now only selects the visible samples (should be much faster with large inventories)
  • The validation for collection_id has been implemented in the CollectionSelect component to ensure that a new collection is only created when a valid collection_id is provided

Addresses #889

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (f7c5550) to head (ef47ab4).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #888   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          62       62           
  Lines        3909     3909           
=======================================
  Hits         2667     2667           
  Misses       1242     1242

@cypress Cypress
Copy link

cypress bot commented Sep 25, 2024 •
edited
Loading

datalab    Run #2428

Run Properties:  status check passed Passed #2428  •  git commit 00a76d508e ℹ️: Merge ef47ab418030d0c52e530fd4f3aff6f92ec58ff1 into f7c555073f10bb591c419ee81395...
Project datalab
Branch Review bc/datatable-fix
Run status status check passed Passed #2428
Run duration 05m 59s
Commit git commit 00a76d508e ℹ️: Merge ef47ab418030d0c52e530fd4f3aff6f92ec58ff1 into f7c555073f10bb591c419ee81395...
Committer Benjamin Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 393
View all changes introduced in this branch ↗︎

@BenjaminCharmes
Fix selectall
dffd7b5 
Fix selectall checkbox in DataTable
@BenjaminCharmes BenjaminCharmes force-pushed the bc/datatable-fix branch 2 times, most recently from 65d4eb3 to d0f8042 Compare September 26, 2024 13:26
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review September 26, 2024 13:38
ml-evs
ml-evs requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @BenjaminCharmes! Did something get fixed with the wrapping of long names too? It seems to work nicely for me now

I just had a couple of really minor suggestions below; I think I will commit these myself and then merge -- perhaps you could tidy up the ID validation in JS since we duplicate it in a few places now?

webapp/src/components/CollectionSelect.vue Outdated Show resolved Hide resolved
webapp/src/components/CollectionSelect.vue Show resolved Hide resolved
@BenjaminCharmes @ml-evs
display error message in collection options in vSelect
ef47ab4 
Fix all-select checkbox

Default row: 20

Apply suggestions from code review
@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface usability labels Sep 26, 2024
ml-evs
ml-evs approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ml-evs ml-evs enabled auto-merge (rebase) September 26, 2024 20:31
@ml-evs ml-evs merged commit 1d63eb6 into main Sep 27, 2024
20 checks passed
@ml-evs ml-evs deleted the bc/datatable-fix branch September 27, 2024 07:21
@BenjaminCharmes BenjaminCharmes mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
usability webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminCharmes @ml-evs