Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange dependencies and update navani #911

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 7, 2024

This PR moves more deps to 'core', which was previously unused. I think this may help dependabot figure out which deps need to be installed alongside each other.

This PR also updates navani to 0.1.7, which includes important fixes for Neware.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (9e2ad38) to head (2b94694).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #911   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files          62       62           
  Lines        3921     3921           
=======================================
  Hits         2680     2680           
  Misses       1241     1241           

Copy link

cypress bot commented Oct 7, 2024

datalab    Run #2506

Run Properties:  status check passed Passed #2506  •  git commit d72265974c ℹ️: Merge 2b94694f460c7cc9ba5442b1eec06b76b0cfdb0b into 9e2ad381db60e6fced9265f35bd0...
Project datalab
Branch Review ml-evs/dependabot-config
Run status status check passed Passed #2506
Run duration 06m 25s
Commit git commit d72265974c ℹ️: Merge 2b94694f460c7cc9ba5442b1eec06b76b0cfdb0b into 9e2ad381db60e6fced9265f35bd0...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit 1fa4e6b into main Oct 7, 2024
20 checks passed
@ml-evs ml-evs deleted the ml-evs/dependabot-config branch October 7, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant