Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rid ourselves of pipenv, requirements files, dev containers and other unecessary complexity #914

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 8, 2024

Most things are replaced by uv, using uv.lock as the authoritative source. Non-locked deps can still be installed normally with pip, until uv and the Python core team eventually decide on a universal lockfile format.

I no longer see any value in maintaining all the original stuff we had, so this PR strips out the Pipfile.lock, updates all the docs instructions and uses uv everywhere in our own builds.

Closes #852

Copy link

cypress bot commented Oct 8, 2024

datalab    Run #2527

Run Properties:  status check passed Passed #2527  •  git commit 3b55ac320e ℹ️: Merge 6a29d4938f67ff57f6fbbe01146be9be015c4d05 into 0869d8c51a74ff0b1eb5c1874ffa...
Project datalab
Run status status check passed Passed #2527
Run duration 07m 00s
Commit git commit 3b55ac320e ℹ️: Merge 6a29d4938f67ff57f6fbbe01146be9be015c4d05 into 0869d8c51a74ff0b1eb5c1874ffa...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396

@ml-evs ml-evs added this to the v0.5.x milestone Oct 8, 2024
INSTALL.md Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@jdbocarsly jdbocarsly self-requested a review October 8, 2024 21:28
jdbocarsly
jdbocarsly previously approved these changes Oct 8, 2024
Copy link
Member

@jdbocarsly jdbocarsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ml-evs ml-evs merged commit ebed305 into main Oct 8, 2024
15 checks passed
@ml-evs ml-evs deleted the ml-evs/final-deps-overhaul branch October 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove pipenv
2 participants