-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rid ourselves of pipenv
, requirements files, dev containers and other unecessary complexity
#914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab Run #2527
Run Properties:
|
Project |
datalab
|
Run status |
Passed #2527
|
Run duration | 07m 00s |
Commit |
3b55ac320e ℹ️: Merge 6a29d4938f67ff57f6fbbe01146be9be015c4d05 into 0869d8c51a74ff0b1eb5c1874ffa...
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
396
|
ml-evs
force-pushed
the
ml-evs/final-deps-overhaul
branch
from
October 8, 2024 15:54
09ee508
to
3f24785
Compare
ml-evs
force-pushed
the
ml-evs/final-deps-overhaul
branch
from
October 8, 2024 15:55
3f24785
to
b2d66ad
Compare
ml-evs
commented
Oct 8, 2024
jdbocarsly
requested changes
Oct 8, 2024
ml-evs
commented
Oct 8, 2024
ml-evs
commented
Oct 8, 2024
ml-evs
commented
Oct 8, 2024
jdbocarsly
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
ml-evs
force-pushed
the
ml-evs/final-deps-overhaul
branch
from
October 8, 2024 21:37
d0e3978
to
2c04e61
Compare
…xt or pipenv Add missing line in install docs Update `INSTALL.md` after review Co-authored-by: Josh Bocarsly <[email protected]> Adjust details in INSTALL instructions
ml-evs
force-pushed
the
ml-evs/final-deps-overhaul
branch
from
October 8, 2024 21:38
2c04e61
to
e17796d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most things are replaced by
uv
, usinguv.lock
as the authoritative source. Non-locked deps can still be installed normally withpip
, untiluv
and the Python core team eventually decide on a universal lockfile format.I no longer see any value in maintaining all the original stuff we had, so this PR strips out the
Pipfile.lock
, updates all the docs instructions and usesuv
everywhere in our own builds.Closes #852